Skip to content

vtk: qt514 -> qt515#106975

Merged
kevincox merged 1 commit intoNixOS:masterfrom
tfmoraes:vtk_qt515
Dec 24, 2020
Merged

vtk: qt514 -> qt515#106975
kevincox merged 1 commit intoNixOS:masterfrom
tfmoraes:vtk_qt515

Conversation

@tfmoraes
Copy link
Contributor

@tfmoraes tfmoraes commented Dec 15, 2020

Motivation for this change

As requested in #104474

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from knedlsepp December 15, 2020 18:48
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 15, 2020
@tfmoraes
Copy link
Contributor Author

It's building almost all packages that depends on VTK. The only ones no building are PCL that is marked as broken and cq-editor but it's because of this error with spyder_3 #100366.

❯ nix-shell -p nixpkgs-review --run "nixpkgs-review pr 106975"                                                                            
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/106975/head:refs/nixpkgs-review/1
From https://github.com/NixOS/nixpkgs
 + 94faa9875fa...e78a2d39f0e refs/pull/106975/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /home/thiago/.cache/nixpkgs-review/pr-106975/nixpkgs a4d86d5425bba49768d7d1374937d44f8e532d09
Preparing worktree (detached HEAD a4d86d5425b)
HEAD is now at a4d86d5425b Merge pull request #106969 from marsam/update-go-tools
$ nix-env -f /home/thiago/.cache/nixpkgs-review/pr-106975/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit e78a2d39f0e33a0c35918e255f31d848dd48e138
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/thiago/.cache/nixpkgs-review/pr-106975/nixpkgs -qaP --xml --out-path --show-trace --meta
32 packages updated:
appcsxcad-unstable cq-editor csxcad-unstable freecad-unstable horizon-eda inkcut inkcut-inkscape-plugin mirtk opencascade-oce opencascade-oce openems-unstable pcl python3.7-cadquery python3.7-enamlx python3.7-python-csxcad-unstable python3.7-python-openems-unstable python3.8-enamlx python3.8-python-csxcad-unstable python3.8-python-openems-unstable python3.9-enamlx python3.9-python-csxcad-unstable python3.9-python-openems-unstable pythonocc-core pythonocc-core pythonocc-core qcsxcad-unstable qcsxcad-unstable qcsxcad-unstable qcsxcad-unstable smesh vtk vtk-qvtk

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/thiago/.cache/nixpkgs-review/pr-106975/build.nix
error: --- Error --- nix-daemon
builder for '/nix/store/ljsmb9ajhxygw4m04mmp8hyf6y74bw6y-python3.7-spyder-kernels-0.5.2.drv' failed with exit code 4; last 10 log lines:
  rootdir: /build/source
  plugins: flaky-3.7.0
  collected 45 items                                                             
  
  ============================ no tests ran in 1.28s =============================
  ERROR: Wrong expression passed to '-k': \
    not test_turtle_launch \
    and not test_umr_skip_cython \
    and not test_umr_pathlist: at column 1: unexpected character "\"
  
error: --- Error --- nix-daemon
1 dependencies of derivation '/nix/store/0yg4pi7qx64wqg2mnrsqzgp06cixichx-python3.7-spyder-3.3.6.drv' failed to build
error: --- Error --- nix-daemon
1 dependencies of derivation '/nix/store/gra8s2pyjdmmkczgwzjk74bxzy9vs1nj-cq-editor-0.1.1.drv' failed to build
error: --- Error --------------------------------------------------------------------------------------------------------------------- nix
1 dependencies of derivation '/nix/store/wgqw1cg63xk8fpwrinsbq8yi6jp3a51k-env.drv' failed to build

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/106975

1 package marked as broken and skipped:
pcl

1 package failed to build:
cq-editor

28 packages built:
appcsxcad csxcad freecad horizon-eda inkcut inkscape-extensions.inkcut qcsxcad libsForQt512.qcsxcad libsForQt514.qcsxcad mirtk opencascade openems python37Packages.cadquery python37Packages.enamlx python37Packages.python-csxcad python37Packages.python-openems python37Packages.pythonocc-core python38Packages.enamlx python38Packages.python-csxcad python38Packages.python-openems python38Packages.pythonocc-core python39Packages.enamlx python39Packages.python-csxcad python39Packages.python-openems python39Packages.pythonocc-core smesh vtk vtkWithQt5

error: --- Error --------------------------------------------------------------------------------------------------------------------- nix
build log of '/nix/store/gra8s2pyjdmmkczgwzjk74bxzy9vs1nj-cq-editor-0.1.1.drv' is not available

@tfmoraes
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 21, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 22, 2020

@glittershark please review.

@glittershark
Copy link
Member

glittershark commented Dec 23, 2020

Seems fine to me, but I'm not familiar enough with this area of the code to comfortably review (sorry)

@glittershark
Copy link
Member

/status needs_reviewer

@kevincox kevincox merged commit c1f95fe into NixOS:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants